Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANNER-2738 Make FlightAssignment comparator consistent with equals #2019

Merged
merged 2 commits into from
Jun 7, 2022
Merged

PLANNER-2738 Make FlightAssignment comparator consistent with equals #2019

merged 2 commits into from
Jun 7, 2022

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jun 7, 2022

Fixes https://github.com/kiegroup/optaplanner-quickstarts/issues/339.

JIRA

https://issues.redhat.com/browse/PLANNER-2738

Referenced pull requests

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    please add comment: Jenkins (re)run [optaplanner|kogito-apps|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] tests

  • for a full downstream build

    • for jenkins job:
      please add comment: Jenkins run fdb
    • for github actions job:
      add the label run_fdb
  • for a compile downstream build
    please add comment: Jenkins run cdb

  • for a full production downstream build
    please add comment: Jenkins execute product fdb

  • for an upstream build
    please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [optaplanner|kogito-apps|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [optaplanner|kogito-apps|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] quarkus-branch

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [optaplanner|kogito-apps|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] native

  • for mandrel checks
    Run native checks against Mandrel image
    Please add comment: Jenkins run mandrel

  • for a specific mandrel check
    Run native checks against Mandrel image
    Please add comment: Jenkins (re)run [optaplanner|kogito-apps|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] mandrel

CI Status

You can check OptaPlanner repositories CI status from Chain Status webpage.

@triceo triceo requested a review from yurloc June 7, 2022 06:51
Copy link
Contributor

@yurloc yurloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Question 1 inline.

Question 2: have you considered adding a reproducer that would prevent reintroducing the bug? That was my original idea but I can see that might be unnecessary for an example code. Up to you.

@triceo
Copy link
Contributor Author

triceo commented Jun 7, 2022

I have considered adding a test but as you say, for an example, I decided not to bother.

@triceo triceo merged commit 020b2bb into apache:main Jun 7, 2022
@triceo triceo deleted the PLANNER-2738 branch June 7, 2022 12:39
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caused by: java.lang.IllegalStateException:
2 participants