-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Refactoring the Result
Class
#7158
Comments
I’d like to proceed once both tasks are completed. Thank you! |
Well done, looking forward to your PR. |
If you're interested, please review PR I created 🙂 |
Sure! |
I want to know which modules are currently involved in refactoring and the classes involved, as we need to understand the scope of this issue. |
I refactored the |
OK, I believe the impact of this change is within a controllable range. You can complete this change through multiple PRs, either by module or by dependency. |
Is it correct to address the impact of this PR through multiple PRs? |
Yes, you can gradually complete the refactoring through multiple PRs. |
Whenever you have time, could you create an issue related to this? |
If you could clarify which specific areas this PR affects, I'll review it and create an issue before proceeding with the work. |
I see that you've submitted a PR, but I'm not quite sure what exactly you need me to confirm or check for you. |
You mean the PR or the comment? |
For the PR, I have refactored the Please review that part when you get a chance. Also, in your comment, you mentioned that my PR affects other parts, but I wasn’t sure exactly which areas you were referring to. Could you clarify which parts are impacted? |
My point is that, based on the scope of changes you described (the Seata module), the impacted areas appear to be within the expected scope. |
Why you need it?
Please check the comments on the PR.
How it could be?
I want to use
type
effectively in theResult
object, just like inSimpleResult
.One idea I have is to move APIs like
success
fromSimpleResult
toResult
.The text was updated successfully, but these errors were encountered: