Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Refactoring the Result Class #7158

Open
YongGoose opened this issue Feb 11, 2025 · 15 comments · May be fixed by #7176
Open

Refactoring: Refactoring the Result Class #7158

YongGoose opened this issue Feb 11, 2025 · 15 comments · May be fixed by #7176
Assignees

Comments

@YongGoose
Copy link
Contributor

Why you need it?

Please check the comments on the PR.

How it could be?

I want to use type effectively in the Result object, just like in SimpleResult.

One idea I have is to move APIs like success from SimpleResult to Result.

@YongGoose
Copy link
Contributor Author

@funky-eyes

I’d like to proceed once both tasks are completed.
Please assign me to this issue.

Thank you! ☺️

@funky-eyes
Copy link
Contributor

Well done, looking forward to your PR.

@YongGoose YongGoose linked a pull request Feb 22, 2025 that will close this issue
1 task
@YongGoose
Copy link
Contributor Author

@xingfudeshi

If you're interested, please review PR I created 🙂

@xingfudeshi
Copy link
Member

@xingfudeshi

If you're interested, please review PR I created 🙂

Sure!

@funky-eyes
Copy link
Contributor

I want to know which modules are currently involved in refactoring and the classes involved, as we need to understand the scope of this issue.

@YongGoose
Copy link
Contributor Author

I want to know which modules are currently involved in refactoring and the classes involved, as we need to understand the scope of this issue.

I refactored the Result class along with its subclasses.
Consequently, the common, console, namingserver, and server modules, which depend on these classes, were also part of the refactoring.

@funky-eyes
Copy link
Contributor

OK, I believe the impact of this change is within a controllable range. You can complete this change through multiple PRs, either by module or by dependency.

@YongGoose
Copy link
Contributor Author

OK, I believe the impact of this change is within a controllable range. You can complete this change through multiple PRs, either by module or by dependency.

Is it correct to address the impact of this PR through multiple PRs?
If I’ve misunderstood, could you please provide further clarification?

@funky-eyes
Copy link
Contributor

OK, I believe the impact of this change is within a controllable range. You can complete this change through multiple PRs, either by module or by dependency.

Is it correct to address the impact of this PR through multiple PRs? If I’ve misunderstood, could you please provide further clarification?

Yes, you can gradually complete the refactoring through multiple PRs.

@YongGoose
Copy link
Contributor Author

Yes, you can gradually complete the refactoring through multiple PRs.

Whenever you have time, could you create an issue related to this?
I’d also really appreciate it if you could add it as a sub-issue under the main one. 🙂

@YongGoose
Copy link
Contributor Author

@funky-eyes

If you could clarify which specific areas this PR affects, I'll review it and create an issue before proceeding with the work.
I'm still not sure which areas this PR affects. 😅

@funky-eyes
Copy link
Contributor

I see that you've submitted a PR, but I'm not quite sure what exactly you need me to confirm or check for you.

@YongGoose
Copy link
Contributor Author

I see that you've submitted a PR, but I'm not quite sure what exactly you need me to confirm or check for you.

You mean the PR or the comment?

@YongGoose
Copy link
Contributor Author

YongGoose commented Feb 24, 2025

@funky-eyes

For the PR, I have refactored the Result class according to the discussion we had in the comments.

Please review that part when you get a chance.

Also, in your comment, you mentioned that my PR affects other parts, but I wasn’t sure exactly which areas you were referring to. Could you clarify which parts are impacted?

@funky-eyes
Copy link
Contributor

My point is that, based on the scope of changes you described (the Seata module), the impacted areas appear to be within the expected scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants