Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Playwright #1024

Closed
rzo1 opened this issue Jan 4, 2023 · 3 comments
Closed

Add support for Playwright #1024

rzo1 opened this issue Jan 4, 2023 · 3 comments
Assignees
@jnioche
Labels
enhancement fetcher
Milestone
3.1.0

Comments

@rzo1
Copy link
Contributor

rzo1 commented Jan 4, 2023

Mainly creating this issue as a possible future request for anyone, who has some time to contribute.

It would be neat to have Playwright protocol impl for SC.

Note, that Playwright can also connect to Selenium Grid , which would make it a cool addition.

Related: #1023
@sebastian-nagel
Copy link
Contributor

Actually, some work is already done in #899/#902

@rzo1
Copy link
Contributor Author

rzo1 commented Jan 4, 2023

Yup - saw the PRs 😎 - thanks for referencing them. Might be a good starting point.

@sam-ulrich1
Copy link
Contributor

The existing work may be fully operational. The problem that stalled out the work was on playwrights side and since the API has not changed it is likely a simple upgrade would fix everything.

The crawler worked but playwright would crash after a couple thousand pages

jnioche added a commit that referenced this issue May 17, 2024
@jnioche
Playwright protocol implementation, fixes #1024
37ccedc 
Signed-off-by: Julien Nioche <[email protected]>
@rzo1 rzo1 added this to the 3.1.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnioche jnioche

Labels
enhancement fetcher
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
4 participants
@jnioche @sebastian-nagel @rzo1 @sam-ulrich1