Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10632][Manager][Sort][Dashboard] Add oceanbase support #10685

Closed
wants to merge 5 commits into from

Conversation

xxsc0529
Copy link
Contributor

@xxsc0529 xxsc0529 commented Jul 22, 2024

Fixes #10632

Motivation

Added support for Oceanbase data sources to adapt to the Oceanbase ecosystem. close #10632

Modifications

It mainly adds oceanbase data source support and uses the oceanbase-client driver to connect.

It mainly adds oceanbase data source support and uses the oceanbase-client driver to connect. And write oceanbase's ExtractNode logic and LoadNode logic. The specific implementation logic is the same as mysql.Added support for oceanbase on the front-end page. Since the jdbc-inlong processing logic in the flink15 connection lacks the jdbc dialect, an error is reported. This is modified here.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)
    Here's how the page test works
    image
    image
    image
    image

  • This change added tests and can be verified as follows:
    Please use the following test classes for testing org.apache.inlong.sort.parser.MySqlExtractNodeToOceanBaseLoadNodeTest
    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no) yes
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) Data source types have been added to the README.md
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xxsc0529, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@dockerzhang dockerzhang changed the title [INLONG-10632][Manager][Sort]:add oceanbase support [INLONG-10632][Manager][Sort] Add oceanbase support Jul 22, 2024
@aloyszhang
Copy link
Contributor

aloyszhang commented Jul 22, 2024

@xxsc0529 Great Job! First of all, thanks for your contribution.

For the convenience of code review and future maintenance, it's better to separate this pull request based on the modules manager, sort, and dashboard.
Also, the Apache InLong community requires an issue for every pull request.

So, there may be issues like:

  • [Feature][Manager] Add Oceanbase support
  • [Feature][Sort] Add Oceanbase support
  • [Feature][Dashboard] Add Oceanbase support

Each issue has one corresponding pull request.

@xxsc0529 xxsc0529 changed the title [INLONG-10632][Manager][Sort] Add oceanbase support [INLONG-10632][Manager][Sort][Dashboard] Add oceanbase support Jul 22, 2024
Connection conn;
try {
Class.forName(OceanBase_DRIVER_CLASS);
conn = DriverManager.getConnection(url, user, password);

Check failure

Code scanning / CodeQL

Server-side request forgery Critical

Potential server-side request forgery due to a
user-provided value
.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the error is filled, the connection will fail, and the database has a security defense mechanism

@aloyszhang
Copy link
Contributor

aloyszhang commented Jul 22, 2024

@xxsc0529 Great Job! First of all, thanks for your contribution.

For the convenience of code review and future maintenance, it's better to separate this pull request based on the modules manager, sort, and dashboard. Also, the Apache InLong community requires an issue for every pull request.

So, there may be issues like:

  • [Feature][Manager] Add Oceanbase support
  • [Feature][Sort] Add Oceanbase support
  • [Feature][Dashboard] Add Oceanbase support

Each issue has one corresponding pull request.

Hi @xxsc0529,
You should split this pull request into 3 parts(3 pull requests) according to the modules, and create an issue for each pull request.

@xxsc0529 xxsc0529 closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Dashboard] dashboard should support oceanbase
2 participants