-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-10632][Manager][Sort][Dashboard] Add oceanbase support #10685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @xxsc0529, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍
@xxsc0529 Great Job! First of all, thanks for your contribution. For the convenience of code review and future maintenance, it's better to separate this pull request based on the modules manager, sort, and dashboard. So, there may be issues like:
Each issue has one corresponding pull request. |
… packaging failures
Connection conn; | ||
try { | ||
Class.forName(OceanBase_DRIVER_CLASS); | ||
conn = DriverManager.getConnection(url, user, password); |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
user-provided value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the error is filled, the connection will fail, and the database has a security defense mechanism
Hi @xxsc0529, |
Fixes #10632
Motivation
Added support for Oceanbase data sources to adapt to the Oceanbase ecosystem. close #10632
Modifications
It mainly adds oceanbase data source support and uses the oceanbase-client driver to connect.
It mainly adds oceanbase data source support and uses the oceanbase-client driver to connect. And write oceanbase's ExtractNode logic and LoadNode logic. The specific implementation logic is the same as mysql.Added support for oceanbase on the front-end page. Since the jdbc-inlong processing logic in the flink15 connection lacks the jdbc dialect, an error is reported. This is modified here.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
Here's how the page test works
This change added tests and can be verified as follows:
Please use the following test classes for testing org.apache.inlong.sort.parser.MySqlExtractNodeToOceanBaseLoadNodeTest
(example:)
Documentation