-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor integration and system tests to remove Zookeeper, add group protocol parameter #17581
Closed
kirktrue
wants to merge
28
commits into
apache:trunk
from
kirktrue:kirktrue-remove-zookeeper-tests-part-1
Closed
Changes from 6 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
965ff03
Upgraded ConsumerWithLegacyMessageFormatIntegrationTest
kirktrue 753626a
Update LogAppendTimeTest.scala
kirktrue 270fde8
Update FetchFromFollowerIntegrationTest.scala
kirktrue 4277b23
Update RemoteTopicCrudTest.scala
kirktrue 61fec39
Update ListOffsetsIntegrationTest.scala
kirktrue cb06a79
Updating BaseProducerSendTest and its subclass PlaintextProducerSendTest
kirktrue 9a46023
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue 18d46e8
Updates to reduce boilerplate
kirktrue 1f6b564
Removed more uses of "zk" as a quorum test parameter
kirktrue c1df673
More clean up to remove ZK tests
kirktrue 322aeb9
Updates for more tests
kirktrue b52488c
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue eabc67c
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue c789dfb
The Great Migration
kirktrue 36535c6
Fixed whitespace change
kirktrue 6400957
Reverted removal of @nowarn
kirktrue 7f0e4a1
Temporarily added getTestQuorumAndGroupProtocolParametersClassicGroup…
kirktrue e3e2c8c
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue a7dd66c
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue 999c528
Support for changing the group.protocol from the default and removing…
kirktrue 1252f08
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue 28248e9
WIP system test updates
kirktrue c02835e
Whitespace and other minor-ish changes
kirktrue e0900f5
Reverting tests to allow them to fail
kirktrue 8d80b63
Hopefully that's obvious enough :)
kirktrue a113f6b
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue 46c6f4a
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue f03f28c
Merge branch 'trunk' into kirktrue-remove-zookeeper-tests-part-1
kirktrue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the proper change here to remove the quorum parameter entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd wondered that and wanted someone to raise the question.
I think it makes sense to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to oblige :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question out to @cmccabe regarding his preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestInfoUtils
uses the parameters to determine if itisKraft()
,isZkMigrationTest()
, etc. Usages of those methods would need to be updated too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm sure, but wouldn't AK 4.0 have all of the ZK migration tests removed, and wouldn't all tests be ZK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some shenanigans done in the base test classes regarding the
quorum
param. Until we remove the ZK bits from that test infra, I think we actually need thequorum
param :-/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the use of "shenanigans" to describe this 👍