Skip to content

Commit ef5d0f2

Browse files
committed
[TEST] Disable concurrency in TestTaxonomyFacetAssociations#testFloatAssociationRandom
The test relies on ordering which requires sequential execution.
1 parent f550856 commit ef5d0f2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,9 @@ public void testFloatSumAssociation() throws Exception {
327327
}
328328

329329
public void testFloatAssociationRandom() throws Exception {
330-
331-
IndexSearcher searcher = newSearcher(reader);
330+
// disabling search concurrency because validateFloats relies on ordering which requires
331+
// sequential execution
332+
IndexSearcher searcher = newSearcher(reader, true, true, false);
332333
FacetsCollector fc =
333334
searcher.search(new TermQuery(new Term("match", "yes")), new FacetsCollectorManager());
334335

@@ -641,7 +642,7 @@ private void validateFloats(
641642
float value = e.getValue();
642643
// We can expect the floats to be exactly equal here since we're ensuring that we sum them
643644
// in the same order when determining expected values and when computing facets. See
644-
// LUCENE-10530:
645+
// LUCENE-10530. This though requires sequential execution.
645646
assertEquals(value, facets.getSpecificValue(dim, e.getKey()).floatValue(), 0f);
646647
aggregatedValue = aggregationFunction.aggregate(aggregatedValue, value);
647648
}

0 commit comments

Comments
 (0)