maxDocBytesToAnalyze should be required arg up front [LUCENE-1560]

[asfimport]

We recently changed IndexWriter to require you to specify up-front
MaxFieldLength, on creation, so that you are aware of this dangerous
"loses stuff" setting. Too many developers had fallen into the trap
of "how come my search can't find this document...".

I think we should do the same with "maxDocBytesToAnalyze" with
highlighter?

Spinoff from this thread:

http://www.nabble.com/Lucene-Highlighting-and-Dynamic-Summaries-p22385887.html

---

Migrated from LUCENE-1560 by Michael McCandless (@mikemccand), updated May 09 2016

[asfimport]

Michael McCandless (@mikemccand) (migrated from JIRA)

Moving out.

[asfimport]

Steven Rowe (@sarowe) (migrated from JIRA)

I think this issue is still valid?

The nabble.com email thread link in the description is broken - here's the markmail.org thread: http://markmail.org/thread/2pcdjsurrrqoxuew.

maxDocBytesToAnalyze() was deprecated as part of #2209 in favor of maxDocCharsToAnalyze(), and then removed with the 3.0 release deprecation removals as part of #3097.

There is one commented-out vestige that ought to be renamed or removed (my vote is removal - this was commented out six years ago):

265: //	  if(lastEndOffset>maxDocBytesToAnalyze)
266: //   {
267: //     break;
268: //   }

[asfimport]

Steven Rowe (@sarowe) (migrated from JIRA)

Bulk move 4.4 issues to 4.5 and 5.0

[asfimport]

Uwe Schindler (@uschindler) (migrated from JIRA)

Move issue to Lucene 4.9.