Refactor>Rename messes up javadoc comment formatting.

[errael]

Apache NetBeans version

Apache NetBeans IDE 25-rc2

What happened

Product Version: Apache NetBeans IDE 25-rc2

Doing refactor>rename messes up javadoc comments that reference the renamed item.

Have observed

• spaces removed after period
• several lines are turned into a single line
• '*' at the beginning of a line are removed for a few consecutive lines

Language / Project Type / NetBeans Component

java

How to reproduce

1. Start NB 25-rc2 with no userdir/cachdir
2. On startup welcome page, NewProject Maven
3. Make file look like test-file below
4. Click on m2 in line 20, use context menu Refactor>Rename
5. Change m2 to someDifferentName

Observe lines 4, 9 (see below): the javadoc comments are incorrectly formatted.

• There is no space after the initial period, ('.').
• Multiple lines are turned into a single line.

Also fails in NB 24. Works in NB 23.

test-file

package mavenproject4;

/**
 * This is the class comment.
 * It references {@link #m1() }.
 * It also references {@link #m2() }.
 */
public class Mavenproject4 {
    /**
     * This is another example.
     * It references {@link #m2() }.
     */
    public void m1() {
    }

    /**
     * This is another example.
     * It references {@link #m1() }.
     */
    public void m2() {
    }
}

after refactor rename

package mavenproject4;

/**
 * This is the class comment.It references {@link #m1()}.
 * It also references {@link #someDifferentName() }.
 */
public class Mavenproject4 {
    /**
     * This is another example.It references {@link #someDifferentName()}.
     */
    public void m1() {
    }

    /**
     * This is another example.
     * It references {@link #m1() }.
     */
    public void someDifferentName() {
    }
}

Did this work correctly in an earlier version?

NetBeans 23

Operating System

Linux harmony 6.9.3-76060903-generic #202405300957173877096822.04~d5f7c84 SMP PREEMPT_DYNAMIC Wed F x86_64 x86_64 x86_64 GNU/Linux

JDK

Java: 23.0.1; OpenJDK 64-Bit Server VM 23.0.1+11-39 Runtime: OpenJDK Runtime Environment 23.0.1+11-39 System: Linux version 6.9.3-76060903-generic running on amd64; UTF-8; en_US (nb)

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

every time

Are you willing to submit a pull request?

No

[errael]

Just looked at some notes. This problem seems to occur in several situations. I'm wondering if there's an option I don't know about.

• "move initializers to constructor" does major screwup.
• formatting problems with update javadoc with "missing @param tag" hint

[errael]

This is a REGRESSION. It worked in NetBeans 23. (updated OP)

[mbien]

seems to be a side effect of #7491, reverted a few PRs and this was the only revert which changed the behavior back to NB 23.

added a slightly modified reproducer to mbien/nb-reprorepo@995e19d

[mbien]

@lahodaj this might also affect the VSCode plugin, comment above has a reproducer with instructions.

[lahodaj]

Will take a look.

[neilcsmith-net]

This is also reminding me of the behaviour before the fix in #6282 (Creating a comment out of extracted first sentence and body not working correctly.)

[lahodaj]

@neilcsmith-net , yes, I think this is about full/split body! Let see how this will work:
#8245