Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] CdcWatermarkStrategy The current system time will always be sent as the watermark value. #2745

Open
2 tasks done
huyuanfeng2018 opened this issue Jan 19, 2024 · 0 comments · May be fixed by #2763
Open
2 tasks done

[Bug] CdcWatermarkStrategy The current system time will always be sent as the watermark value. #2745

huyuanfeng2018 opened this issue Jan 19, 2024 · 0 comments · May be fixed by #2763
Labels
bug Something isn't working

Comments

@huyuanfeng2018
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Paimon version

master

Compute Engine

flink

Minimal reproduce step

Appears in any case, as long as watermark is generated.
onPeriodicEmit is called periodically, so the system timestamp will be periodically sent out as a watermark. This is not what we expect.

https://github.com/apache/incubator-paimon/blob/1bc33d9f606e84c2341cea4e604ce17d6651921f/paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/watermark/CdcWatermarkStrategy.java#L63

What doesn't meet your expectations?

Watermark should be generated based on the time in the data, here all are system timestamp

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@huyuanfeng2018 huyuanfeng2018 added the bug Something isn't working label Jan 19, 2024
@huyuanfeng2018 huyuanfeng2018 changed the title [Bug] CdcWatermarkStrategy The current time point will always be sent as the watermark value. [Bug] CdcWatermarkStrategy The current system time will always be sent as the watermark value. Jan 19, 2024
@huyuanfeng2018 huyuanfeng2018 linked a pull request Jan 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cdc] fix cdc watermark value emit error huyuanfeng2018/incubator-paimon
1 participant
@huyuanfeng2018