-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][test] Add solution to PulsarMockBookKeeper for intercepting reads #23875
Merged
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-pulsar-mock-bookkeeper-read-interceptor
Jan 23, 2025
Merged
[improve][test] Add solution to PulsarMockBookKeeper for intercepting reads #23875
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-pulsar-mock-bookkeeper-read-interceptor
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lhotari
requested review from
Technoboy-,
nodece,
dao-jun,
shibd,
eolivelli,
nicoloboschi and
thetumbled
January 22, 2025 08:06
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23875 +/- ##
============================================
+ Coverage 73.57% 74.16% +0.58%
+ Complexity 32624 31815 -809
============================================
Files 1877 1853 -24
Lines 139502 143619 +4117
Branches 15299 16311 +1012
============================================
+ Hits 102638 106509 +3871
+ Misses 28908 28727 -181
- Partials 7956 8383 +427
Flags with carried forward coverage won't be shown. Click here to find out more. |
pdolif
approved these changes
Jan 22, 2025
Technoboy-
approved these changes
Jan 23, 2025
4 tasks
Merged
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 31, 2025
… reads (apache#23875) (cherry picked from commit 87fb442) (cherry picked from commit 38f15bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.10
release/3.3.5
release/4.0.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Pulsar tests, in-memory PulsarMockBookKeeper is used to implement BookKeeper client API.
There hasn't been a way to write realistic tests where there's variable latencies in BookKeeper reads.
Adding tests for various broker cache scenarios will benefit from this test framework improvement.
Example usage:
The same approach can be used to inject failures.
Modifications
Add
PulsarMockReadHandleInterceptor
interface and implement it inPulsarMockBookKeeper
.Documentation
doc
doc-required
doc-not-needed
doc-complete