Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simplify integration_tests/charts/api_tests.py #25207

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented Sep 6, 2023

SUMMARY

This PR simplifies integration_tests/charts/api_tests.py by parameterizing some tests that basically do the same.
Additional tests added to cover an empty filter value for chart_all_text, chart_has_created_by and chart_is_certified.

TESTING INSTRUCTIONS

scripts/tests/run.sh --module tests/integration_tests/charts/api_tests.py

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

Hey @sebastianliebscher - hope all is well. Are you still around and able to give this a rebase and help it pass E2E tests? I'll go ahead and convert it to a draft for now. You're very much on track to be a committer, please reach out onslack if you're interested in that opportunity.

@rusackas rusackas marked this pull request as draft August 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants