Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ephemeral envs fail on noop #31236

Merged
merged 4 commits into from
Dec 9, 2024
Merged

fix: ephemeral envs fail on noop #31236

merged 4 commits into from
Dec 9, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Dec 2, 2024

SUMMARY

When an PR comment is different from testenv up|down the workflow does not fail/stop.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Dec 2, 2024
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Dec 2, 2024
@dpgaspar dpgaspar marked this pull request as draft December 2, 2024 16:06
mistercrunch
mistercrunch approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar marked this pull request as ready for review December 8, 2024 18:17
@mistercrunch
Copy link
Member

Looking to test this today and see if that fixes things. Merging and testing since this needs to be in master to work

@mistercrunch mistercrunch merged commit 654701a into apache:master Dec 9, 2024
33 checks passed
@mistercrunch mistercrunch deleted the fix/ephemeral-envs branch December 9, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code review:draft size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @mistercrunch @michael-s-molina