Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSLClientCoordinator: SSL config is reloaded multiple times #11724

Open
cmcfarlen opened this issue Aug 20, 2024 · 2 comments
Open

SSLClientCoordinator: SSL config is reloaded multiple times #11724

cmcfarlen opened this issue Aug 20, 2024 · 2 comments

Comments

@cmcfarlen
Copy link
Contributor

If multiple ssl related config files are changed and then traffic_ctl config reload is executed, the ssl config will reload multiple times.

Reproduction:

  1. Run traffic_server with a sni.yaml and ssl_multicert.config file configured
  2. touch sni.yaml
  3. traffic_ctl config reload
  4. Observerve the log output:
[Aug 20 13:59:35.145] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/sni.yaml loading ...
[Aug 20 13:59:35.147] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/sni.yaml finished loading
[Aug 20 13:59:35.147] [ET_TASK 0] NOTE: ssl_multicert.config loading ...
[Aug 20 13:59:35.158] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/ssl_multicert.config finished loading
  1. touch sni.yaml and ssl_multicert.config files
  2. traffic_ctl config reload
  3. Observer the log output:
[Aug 20 13:59:53.154] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/sni.yaml loading ...
[Aug 20 13:59:53.156] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/sni.yaml finished loading
[Aug 20 13:59:53.156] [ET_TASK 0] NOTE: ssl_multicert.config loading ...
[Aug 20 13:59:53.166] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/ssl_multicert.config finished loading
[Aug 20 13:59:53.166] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/sni.yaml loading ...
[Aug 20 13:59:53.167] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/sni.yaml finished loading
[Aug 20 13:59:53.168] [ET_TASK 0] NOTE: ssl_multicert.config loading ...
[Aug 20 13:59:53.174] [ET_TASK 0] NOTE: /opt/ats/etc/trafficserver/ssl_multicert.config finished loading

This happens because the callbacks setup in SSLClientCoordinator are independently attached and so the reconfigure function will be called for every updated config item specified.

This happens on the master branch, but also for 9.2.x

@JosiahWI
Copy link
Contributor

Is this closed by #11723 @cmcfarlen @maskit?

@maskit
Copy link
Member

maskit commented Aug 21, 2024

No, we found the QUIC reload issue while we work on this one. With #11723 fixed, we'd see 4 "ssl_multicert.config loading ..." lines in total if QUIC is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants