Skip to content

Commit

Permalink
Use junit-jupiter-engine instead of junit-pioneer
Browse files Browse the repository at this point in the history
junit-pioneer:2.1.0 still depends on junit 5.9.2

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
  • Loading branch information
martin-g committed Sep 11, 2023
1 parent 9e5ae89 commit 1bd18d7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
12 changes: 3 additions & 9 deletions wicket-migration/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
</parent>
<artifactId>wicket-migration</artifactId>
<name>Wicket Migration</name>

<dependencyManagement>
<dependencies>
<dependency>
Expand All @@ -33,12 +34,6 @@
<version>24.0.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit-pioneer</groupId>
<artifactId>junit-pioneer</artifactId>
<version>2.1.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.openrewrite.recipe</groupId>
<artifactId>rewrite-recipe-bom</artifactId>
Expand All @@ -54,9 +49,8 @@
<artifactId>rewrite-migrate-java</artifactId>
</dependency>
<dependency>
<groupId>org.junit-pioneer</groupId>
<artifactId>junit-pioneer</artifactId>
<scope>test</scope>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
</dependency>
<dependency>
<groupId>org.openrewrite</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

package org.apache.wicket.migration;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junitpioneer.jupiter.ExpectedToFail;
import org.openrewrite.config.Environment;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
Expand Down Expand Up @@ -78,7 +78,7 @@ class ATest {
}

@Test
@ExpectedToFail("Requires first release of 10.x before we can update the version")
@Disabled("Requires first release of 10.x before we can update the version")
void migrateDependencies() {
//language=xml
rewriteRun(
Expand Down

0 comments on commit 1bd18d7

Please sign in to comment.