WICKET-7024 decode PackageResourceReference URL attributes only insid… #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e requests for it
martin-g
approved these changes
Oct 28, 2024
| tester.executeUrl( | ||
| "wicket/resource/org.apache.wicket.core.request.resource.PackageResourceReferenceTest/a.css?-orange"); | ||
|
|
||
| assertThat(tester.getLastResponseAsString(), containsString("orange")); |
There was a problem hiding this comment.
Also assert that there is no blue
- test cases - code refactoring - WIP: the fix works only to mounted resources, next step is to make it work with the BasicResourceReferenceMapper
pedrosans
force-pushed
the
WICKET-7024-conditional-url-decoding
branch
from
73b4b0e to
0ca4f62
Compare
bitstorm
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conditional reading of URL attributes when decoding the resource locale, style, etc. from it