Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wicket 7125 set bean manager #1022

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

pedrosans
Copy link
Contributor

New CdiConfiguration.setBeanManager method enabling unit tests to configure cdi-unit's BeanManager in the application

@pedrosans pedrosans force-pushed the WICKET-7125-setBeanManager branch 3 times, most recently from e7fe6d3 to c4baa33 Compare October 30, 2024 18:15
@bitstorm
Copy link
Contributor

bitstorm commented Oct 31, 2024

I guess we also need to create a separate branch for 10.x since this feature is the first targeted for version 11. No big deal, I can do it in the next days before merging this PR

@martin-g
Copy link
Member

martin-g commented Nov 4, 2024

I see no reason to keep this only for 11.x.
@bitstorm What is the API break for 10.x ?

@bitstorm
Copy link
Contributor

bitstorm commented Nov 4, 2024

@martin-g my concern is if it is legit introducing a new module for API compatibility. Maybe we can use japicmp-maven-plugin to test if this change is acceptable.

@martin-g
Copy link
Member

martin-g commented Nov 4, 2024

The new module is only for tests.
The tests from one module are extracted into their own module. I see no problems here.

@pedrosans pedrosans force-pushed the WICKET-7125-setBeanManager branch 2 times, most recently from 5d6bd76 to 7a3237b Compare November 5, 2024 21:15
@martin-g
Copy link
Member

@bitstorm In my humble opinion branch-10.x should be deleted and master should be used for 10.x releases until we really have an API break that requires the extra branches.
There are not many active developers at the moment and maintaining several branches just adds load.

@bitstorm
Copy link
Contributor

bitstorm commented Dec 3, 2024

sorry @martin-g , I've totally lost your last comment. Yes, I think you are right about branches. I will set back master branch as 10.x branch

@martin-g
Copy link
Member

martin-g commented Dec 4, 2024

Thank you, @bitstorm !

@bitstorm
Copy link
Contributor

bitstorm commented Dec 4, 2024

@pedrosans @martin-g I think we can proceed with merge.

@pedrosans pedrosans force-pushed the WICKET-7125-setBeanManager branch from 52c9a9c to c5c23ee Compare December 4, 2024 22:31
@pedrosans pedrosans merged commit a59f586 into apache:master Dec 4, 2024
0 of 3 checks passed
@bitstorm
Copy link
Contributor

bitstorm commented Dec 5, 2024

Thank you @pedrosans !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants