-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wicket 7125 set bean manager #1022
Conversation
e7fe6d3
to
c4baa33
Compare
I guess we also need to create a separate branch for 10.x since this feature is the first targeted for version 11. No big deal, I can do it in the next days before merging this PR |
I see no reason to keep this only for 11.x. |
@martin-g my concern is if it is legit introducing a new module for API compatibility. Maybe we can use japicmp-maven-plugin to test if this change is acceptable. |
The new module is only for tests. |
5d6bd76
to
7a3237b
Compare
@bitstorm In my humble opinion |
sorry @martin-g , I've totally lost your last comment. Yes, I think you are right about branches. I will set back master branch as 10.x branch |
Thank you, @bitstorm ! |
@pedrosans @martin-g I think we can proceed with merge. |
52c9a9c
to
c5c23ee
Compare
Thank you @pedrosans ! |
New CdiConfiguration.setBeanManager method enabling unit tests to configure cdi-unit's BeanManager in the application