[WICKET-7068] Tree styles are updated to be RTL-friendly #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solomax
force-pushed
the
tree-rtl-styling
branch
from
1a5575c
to
0ce052c
Compare
|
@solomax Maybe create a second example page with dir="rtl" |
|
I'm not sure what would be the best way in this case :( It might be some sort of dropdown (so every page can be checked in RTL), but this might be useless due to all contents is in English .... |
martin-g
approved these changes
Aug 21, 2023
solomax
changed the title
|
I'm going to merge this one :) |
|
@solomax Should this be ported to |
solomax
added a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one can be tested at https://examples9x.wicket.apache.org/tree by setting
dir="rtl"attribute for<html>tagI'll create JIRA if this PR will be considered useful :)