Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with JDK 17 & 21 #607

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Build and test with JDK 17 & 21 #607

merged 8 commits into from
Sep 11, 2023

Commits on Sep 11, 2023

  1. Build and test with JDK 17 & 21 

    Update Maven in CI to 3.9.4 (latest stable)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f54ab00 View commit details
    Browse the repository at this point in the history

  2. Bump Mockito to 5.5.0 

    Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    091c98b View commit details
    Browse the repository at this point in the history

  3. Do not use Mockito to create a mock of java.io.File class 

    It fails on JdK 21 with:
```
[ERROR]   FilesTest.dontWaitTooMuchIfCantDelete:96 Mockito
Mockito cannot mock this class: class java.io.File.

If you're not sure why you're getting this error, please open an issue on GitHub.

Java               : 21
JVM vendor name    : Oracle Corporation
JVM vendor version : 21+35-2513
JVM name           : OpenJDK 64-Bit Server VM
JVM version        : 21+35-2513
JVM info           : mixed mode, sharing
OS name            : Linux
OS version         : 6.2.0-10018-tuxedo

You are seeing this disclaimer because Mockito is configured to create inlined mocks.
You can learn about inline mocks and their limitations under item #39 of the Mockito class javadoc.

Underlying exception : org.mockito.exceptions.base.MockitoException: Could not modify all classes [interface java.io.Serializable, class java.lang.Object, class java.io.File, interface java.lang.Comparable]
```

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5b82817 View commit details
    Browse the repository at this point in the history

  4. Fix failing tests on JDK 21 

    The problem is explained at https://bugs.openjdk.org/browse/JDK-8304925

Update Byte-Buddy to fix failing tests due to Mockito not able to create
mocks

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2d19d34 View commit details
    Browse the repository at this point in the history

  5. Update org.openrewrite.recipe:rewrite-recipe-bom to support Java 21 

    Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7bd27df View commit details
    Browse the repository at this point in the history

  6. Test against JDK 22-ea too 

    Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d15e2ea View commit details
    Browse the repository at this point in the history

  7. 22-ea is not yet available at adoptium.net 

    Test against latest stable - JDK 20

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    53eb0c8 View commit details
    Browse the repository at this point in the history

  8. Add a Maven profile for JDK 21 

    Fix the version of EA
Update maven-javadoc-plugin

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    @martin-g
    martin-g committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    355597e View commit details
    Browse the repository at this point in the history