Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check the validity of configuration parameters #1005

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: check the validity of configuration parameters #1005

merged 2 commits into from
Nov 21, 2024

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt linked an issue Sep 4, 2024 that may be closed by this pull request
[BUG] Changing a non-existent parameter will cause MySQL to terminate. apecloud/kubeblocks#8079
Closed
@shanshanying
Copy link
Contributor

by restricting the validation rules, it seems only parameters explicitly defined can be updated. (or an optional work-around is to edit corresponding configmap). my question is:

  • what if user performs a minor version upgrading on a cluster. There might be new parameters in the new version. All updates on these new parameters will be rejected.
  • with reRenderResourceTypes api , parameters will be rendered after HScale or VScale. And users' modifictions on this configmap might be lost

nayutah
nayutah previously approved these changes Sep 4, 2024
View reviewed changes
shanshanying
shanshanying previously approved these changes Sep 24, 2024
View reviewed changes
@sophon-zt sophon-zt dismissed stale reviews from shanshanying and nayutah via d0fd184 September 24, 2024 07:27
@sophon-zt sophon-zt force-pushed the bugfix/changing-a-non-existent-parameter-will-cause-mysql-to-terminate-issue8079-issue8079 branch from 6e1f501 to d0fd184 Compare September 24, 2024 07:27
@sophon-zt sophon-zt requested a review from zjx20 as a code owner September 24, 2024 07:27
@shanshanying shanshanying merged commit 56739dc into main Nov 21, 2024
17 checks passed
@shanshanying shanshanying deleted the bugfix/changing-a-non-existent-parameter-will-cause-mysql-to-terminate-issue8079-issue8079 branch November 21, 2024 03:15
@shanshanying
Copy link
Contributor

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks-addons/actions/runs/11945928858

apecloud-bot pushed a commit that referenced this pull request Nov 21, 2024
@sophon-zt @shanshanying
fix: check the validity of configuration parameters (#1005)
232c132 
(cherry picked from commit 56739dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanshanying shanshanying shanshanying approved these changes

@zjx20 zjx20 zjx20 approved these changes

@nayutah nayutah nayutah left review comments

@ldming ldming Awaiting requested review from ldming

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@wangyelei wangyelei Awaiting requested review from wangyelei

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

@weicao weicao Awaiting requested review from weicao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Changing a non-existent parameter will cause MySQL to terminate.
5 participants
@sophon-zt @shanshanying @apecloud-bot @zjx20 @nayutah