fix: TLS_ENABLED might not be defined #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon-inf
requested review from
kizuna-lek,
Y-Rookie,
a team,
ldming,
1aal,
free6om,
sophon-zt and
xuriwuyun
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 69 69
Lines 6682 6682
=====================================
Misses 6682 6682 ☔ View full report in Codecov by Sentry. |
sophon-zt
previously approved these changes
Dec 6, 2024
wangyelei
previously approved these changes
Dec 6, 2024
wangyelei
reviewed
Dec 6, 2024
| @@ -30,14 +30,14 @@ | |||
| <raft_logs_level>warning</raft_logs_level> | |||
| </coordination_settings> | |||
| <raft_configuration> | |||
| {{- if eq $.TLS_ENABLED "true" }} | |||
| {{- if and (index . "TLS_ENABLED") (eq .TLS_ENABLED "true") }} | |||
There was a problem hiding this comment.
render failed with nest scope, define a var to resolve it
leon-inf
force-pushed
the
bugfix/has-no-key-tls-enabled
branch
from
8dad780 to
2d60132
Compare
|
/approve |
apecloud-bot
approved these changes
Dec 6, 2024
zjx20
approved these changes
Dec 6, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit 2fa7631)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve apecloud/kubeblocks#8598