chore: remove deprecated built in KB_XXX envs #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Rookie
requested review from
xuriwuyun,
leon-inf,
a team,
ldming,
kubeJocker,
free6om,
ahjing99 and
shanshanying
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 69 69
Lines 6685 6685
=====================================
Misses 6685 6685 ☔ View full report in Codecov by Sentry. |
xuriwuyun
previously approved these changes
Dec 18, 2024
shanshanying
previously approved these changes
Dec 18, 2024
zjx20
reviewed
Dec 18, 2024
| @@ -44,7 +44,7 @@ fi | |||
|
|
|||
| echo $endpoints | |||
|
|
|||
| topology_fags="--topo_implementation etcd2 --topo_global_server_address ${endpoints} --topo_global_root /vitess/${KB_NAMESPACE}/${KB_CLUSTER_NAME}/global" | |||
| topology_fags="--topo_implementation etcd2 --topo_global_server_address ${endpoints} --topo_global_root /vitess/${NAMESPACE}/${CLUSTER_NAME}/global" | |||
There was a problem hiding this comment.
CLUSTER_NAMESPACE?
fixed
Y-Rookie
dismissed stale reviews from shanshanying and xuriwuyun
via
244be4e
zjx20
approved these changes
Dec 18, 2024
shanshanying
approved these changes
Dec 18, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
(cherry picked from commit 12a9bfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.