feat: Doris Cluster Addon #183
Conversation
yuqun20230302
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf and
shanshanying
as code owners
|
|
||
| if [[ -n "$FE_SERVERS" && -n "$BE_ADDR" ]]; then | ||
| RUN_TYPE="ELECTION" | ||
| if [[ $FE_SERVERS =~ ^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$ || $FE_SERVERS =~ ^.+:([0-9a-fA-F]{1,4}:){7,7}([0-9a-fA-F]{1,4}|:)|([0-9a-fA-F]{1,4}:){1,6}(:[0-9a-fA-F]{1,4}|:)|([0-9a-fA-F]{1,4}:){1,5}((:[0-9a-fA-F]{1,4}){1,2}|:)|([0-9a-fA-F]{1,4}:){1,4}((:[0-9a-fA-F]{1,4}){1,3}|:)|([0-9a-fA-F]{1,4}:){1,3}((:[0-9a-fA-F]{1,4}){1,4}|:)|([0-9a-fA-F]{1,4}:){1,2}((:[0-9a-fA-F]{1,4}){1,5}|:)|[0-9a-fA-F]{1,4}:((:[0-9a-fA-F]{1,4}){1,6}|:)|:((:[0-9a-fA-F]{1,4}){1,7}|:)$ ]]; then |
There was a problem hiding this comment.
please don't copy the code and move this check to a separate function
There was a problem hiding this comment.
sorry，Do you mean that this part of the doris script changes should be written in the mirror instead of exposed changes
There was a problem hiding this comment.
entry_point.sh is doris official be and cn execute scripts, these codes are not exactly the same, I just reduce some redundant judgment, speed up the startup
| metadata: | ||
| name: {{ include "doris.name" . }}-backup-policy-template | ||
| labels: | ||
| clusterdefinition.kubeblocks.io/name: doris # 通过 label 指定作用域，必须填 |
There was a problem hiding this comment.
please use English and check others similar.
There was a problem hiding this comment.
thanks, I have checked the Doris-related parts of the code and modified all of them which is not using English
|
It would be even better if screenshots of the tests for each feature could be provided. |
| // The port of the brpc on the BE, used for communication between the BE default 9060 | ||
| brpc_port: int | ||
| // Whether https is supported. If yes, configure ssl_certificate_path and ssl_private_key_path in be.conf default false | ||
| enable_https: bool |
There was a problem hiding this comment.
Maybe format the cue files： cue fmt addons/doris/configs/*.cue
There was a problem hiding this comment.
thanks,I have formatted the cue files
Doris Cluster Addon Support