chore: refactor postgresql addon and add scripts ut #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Y-Rookie
commented
Aug 27, 2024
•
Y-Rookie
commented
- Refactor lifecycle actions based on the new API and kbagent.
- Remove all references to built-in KB_XX environment variables.
- Eliminate dependencies on the Downward API and other similar dependencies.
- Refactor scripts and add corresponding unit tests (ut).
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf,
shanshanying and
weicao
as code owners
ldming
reviewed
Aug 28, 2024
JashBook
reviewed
Aug 28, 2024
JashBook
reviewed
Aug 28, 2024
xuriwuyun
reviewed
Aug 28, 2024
| - name: postgresql | ||
| - name: {{ include "postgresql-cluster.component-name" . }} | ||
| labels: | ||
| {{- include "postgresql-cluster.patroni-scope-label" . | indent 8 }} |
There was a problem hiding this comment.
how to specify the pg version when install the chart?
There was a problem hiding this comment.
how to specify the pg version when install the chart?
This is not within the scope of this PR. The version will be specified through serviceVersion in the future, but the management of serviceVersion requires further design.
ldming
previously approved these changes
Aug 29, 2024
xuriwuyun
previously approved these changes
Aug 29, 2024
|
/approve |
apecloud-bot
approved these changes
Sep 3, 2024
ldming
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.