chore: get test pkgs from gh vars (#5552)

apecloud · Oct 20, 2023 · 3657e54 · 3657e54
1 parent 14c9524
commit 3657e54
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 12 deletions.
diff --git a/.github/utils/utils.sh b/.github/utils/utils.sh
@@ -615,15 +615,30 @@ set_size_label() {
     fi
 }
 
+skip_check_pkg() {
+    check_pkg=${1:-""}
+    skip="false"
+    if [[ -z "$check_pkg" ]]; then
+        echo "$skip"
+        return
+    fi
+    for skip_pkg in $(echo "$IGNORE_PKGS" | sed 's/|/ /g'); do
+        if [[ "$check_pkg" == "$skip_pkg" ]]; then
+            skip="true"
+            break
+        fi
+    done
+    echo "$skip"
+}
+
 set_test_packages() {
     pkgs_dir=$1
     if ( find $pkgs_dir -maxdepth 1 -type f -name '*_test.go' ) > /dev/null; then
-        # skip check
-        case $pkgs_dir in
-            pkg/client)
-                return
-            ;;
-        esac
+        skip_check=$(skip_check_pkg "$pkgs_dir")
+        if [[ "$skip_check" == "true" ]]; then
+            echo "skip check pkg:$pkgs_dir"
+            return
+        fi
         if [[ -z "$TEST_PACKAGES" ]]; then
             TEST_PACKAGES="{\"ops\":\"$pkgs_dir\"}"
         else

diff --git a/.github/workflows/cicd-pull-request.yml b/.github/workflows/cicd-pull-request.yml
@@ -43,8 +43,9 @@ jobs:
 
           TEST_PACKAGES=`bash .github/utils/utils.sh --type 16 \
               --trigger-type "$TRIGGER_MODE" \
-              --test-pkgs "pkg|apis|controllers|cmd|lorry" \
-              --test-check "mod-vendor|lint|staticcheck"`
+              --test-pkgs "${{ vars.TEST_PKGS }}" \
+              --test-check "${{ vars.TEST_CHECK }}" \
+              --ignore-pkgs "${{ vars.SKIP_CHECK_PKG }}"`
           echo "$TEST_PACKAGES"
           echo "matrix={\"include\":[$TEST_PACKAGES]}" >> $GITHUB_OUTPUT
 
@@ -109,7 +110,7 @@ jobs:
         run: |
           bash .github/utils/utils.sh --type 14 \
               --file cover.out \
-              --ignore-pkgs "cmd/|pkg/cli|pkg/client|pkg/controller/model|controllers/k8score"
+              --ignore-pkgs "${{ vars.IGNORE_COVERAGE_PKG }}"
 
       - name: upload coverage report
         uses: codecov/codecov-action@v3

diff --git a/.github/workflows/cicd-push.yml b/.github/workflows/cicd-push.yml
@@ -157,7 +157,7 @@ jobs:
         run: |
           bash .github/utils/utils.sh --type 14 \
               --file cover.out \
-              --ignore-pkgs "cmd/|pkg/cli|pkg/client|pkg/controller/model|controllers/k8score"
+              --ignore-pkgs "${{ vars.IGNORE_COVERAGE_PKG }}"
 
       - name: upload coverage report
         uses: codecov/codecov-action@v3

diff --git a/.github/workflows/release-version.yml b/.github/workflows/release-version.yml
@@ -31,8 +31,9 @@ jobs:
 
           TEST_PACKAGES=`bash .github/utils/utils.sh --type 16 \
               --trigger-type "[test]" \
-              --test-pkgs "internal|apis|controllers|cmd" \
-              --test-check "mod-vendor|lint"`
+              --test-pkgs "${{ vars.TEST_PKGS }}" \
+              --test-check "${{ vars.TEST_CHECK }}" \
+              --ignore-pkgs "${{ vars.SKIP_CHECK_PKG }}"`
           echo "matrix={\"include\":[$TEST_PACKAGES]}" >> $GITHUB_OUTPUT
 
   release-test: