chore: emit InvalidSpec event

cmd/manager/main.go

@@ -499,7 +499,7 @@ func main() {
 		if err = (&workloadscontrollers.InstanceSetReconciler{
 			Client:   client,
 			Scheme:   mgr.GetScheme(),
-			Recorder: mgr.GetEventRecorderFor("replicated-state-machine-controller"),
+			Recorder: mgr.GetEventRecorderFor("instance-set-controller"),
 		}).SetupWithManager(mgr, multiClusterMgr); err != nil {
 			setupLog.Error(err, "unable to create controller", "controller", "InstanceSet")
 			os.Exit(1)

pkg/controller/instanceset/instance_util.go

@@ -433,13 +433,17 @@ func validateSpec(its *workloads.InstanceSet, tree *kubebuilderx.ObjectTree) err
 		}
 		replicasInTemplates += replicas
 		if templateNames.Has(template.Name) {
-			return fmt.Errorf("duplicate instance template name: %s", template.Name)
+			err = fmt.Errorf("duplicate instance template name: %s", template.Name)
+			tree.EventRecorder.Event(its, corev1.EventTypeWarning, EventReasonInvalidSpec, err.Error())
+			return err
 		}
 		templateNames.Insert(template.Name)
 	}
 	// sum of spec.templates[*].replicas should not greater than spec.replicas
 	if replicasInTemplates > *its.Spec.Replicas {
-		return fmt.Errorf("total replicas in instances(%d) should not greater than replicas in spec(%d)", replicasInTemplates, *its.Spec.Replicas)
+		err = fmt.Errorf("total replicas in instances(%d) should not greater than replicas in spec(%d)", replicasInTemplates, *its.Spec.Replicas)
+		tree.EventRecorder.Event(its, corev1.EventTypeWarning, EventReasonInvalidSpec, err.Error())
+		return err
 	}
 
 	return nil

pkg/controller/instanceset/types.go

@@ -64,6 +64,10 @@ const (
 	)
 )
 
+const (
+	EventReasonInvalidSpec = "InvalidSpec"
+)
+
 const (
 	// MaxPlainRevisionCount specified max number of plain revision stored in status.updateRevisions.
 	// All revisions will be compressed if exceeding this value.