Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features] kbcli cluster create dry-run with all related CR displayed #4752

Closed
free6om opened this issue Aug 15, 2023 · 2 comments
Closed

[Features] kbcli cluster create dry-run with all related CR displayed #4752

free6om opened this issue Aug 15, 2023 · 2 comments

Comments

@free6om
Copy link
Contributor

free6om commented Aug 15, 2023

currently dry-run will only display Cluster CR, should provide a way to display the referenced CD & CV as well.

@ldming
Copy link
Collaborator

ldming commented Aug 18, 2023

The YAML for the cluster already includes the name of CD and CV. Users can get more detailed information by using kubectl get cd CD-NAME based on this information. However, outputting the YAML contents of CD and CV in the cluster dry-run would result in a large amount of output from the dry-run. Are you sure this is necessary?

@ahjing99 ahjing99 modified the milestones: Release 0.6.0, Release 0.7.0 Aug 21, 2023
@free6om
Copy link
Contributor Author

free6om commented Oct 9, 2023

The YAML for the cluster already includes the name of CD and CV. Users can get more detailed information by using kubectl get cd CD-NAME based on this information. However, outputting the YAML contents of CD and CV in the cluster dry-run would result in a large amount of output from the dry-run. Are you sure this is necessary?

seems reasonable to me, will suggest this as the best practice.

@free6om free6om closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants