Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Separate the registry and repository of apecloud images #4915

Closed
JashBook opened this issue Aug 30, 2023 · 3 comments · Fixed by #5596
Closed

[Improvement] Separate the registry and repository of apecloud images #4915

JashBook opened this issue Aug 30, 2023 · 3 comments · Fixed by #5596
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request
Milestone

Comments

@JashBook
Copy link
Collaborator

JashBook commented Aug 30, 2023

Is your improvement request related to a problem? Please describe.
The registry and repository of some apecloud images are hardcoded

If this is a new function, please describe the motivation and goals.
Separate the registry and repository of apecloud images
e.g.
image

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or functions you've considered.

Additional context
image

@JashBook JashBook added the kind/enhancement New feature or request label Aug 30, 2023
@JashBook JashBook added this to the Release 0.7.0 milestone Aug 30, 2023
@wonbin2011
Copy link
Contributor

I'm glad to undertake it.

@shanshanying shanshanying added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed call-for-participation labels Sep 22, 2023
@JashBook JashBook removed this from the Release 0.7.0 milestone Oct 8, 2023
@wonbin2011
Copy link
Contributor

1697859931682
that means if it is not appecloud image, don't have to deal with ?
for example:
repository: docker.io/greptime/greptimedb

@JashBook
Copy link
Collaborator Author

1697859931682 that means if it is not appecloud image, don't have to deal with ? for example: repository: docker.io/greptime/greptimedb

Of course, we're glad you can tweak it too.
But please keep its original registry and repository, such as docker.io and greptime/greptimedb.

@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants