Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: etcd powered by rsm #5272

Merged
merged 5 commits into from
Oct 31, 2023
Merged

chore: etcd powered by rsm #5272

merged 5 commits into from
Oct 31, 2023

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Sep 26, 2023

fix #5101
fix #5650

@free6om free6om added the rsm label Sep 26, 2023
@free6om free6om added this to the Release 0.7.0 milestone Sep 26, 2023
@free6om free6om self-assigned this Sep 26, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (396bbfd) 70.47% compared to head (9ead759) 70.54%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5272      +/-   ##
==========================================
+ Coverage   70.47%   70.54%   +0.07%     
==========================================
  Files         273      273              
  Lines       31167    31171       +4     
==========================================
+ Hits        21964    21989      +25     
+ Misses       7409     7393      -16     
+ Partials     1794     1789       -5     
Flag Coverage Δ
unittests 70.54% <94.11%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...workloads/v1alpha1/replicatedstatemachine_types.go 100.00% <ø> (ø)
controllers/apps/operations/stop.go 77.94% <ø> (+1.31%) ⬆️
...roller/builder/builder_replicated_state_machine.go 94.11% <100.00%> (+0.17%) ⬆️
pkg/controller/rsm/transformer_deletion.go 76.00% <100.00%> (+2.08%) ⬆️
pkg/controller/rsm/transformer_init.go 100.00% <100.00%> (ø)
...kg/controller/rsm/transformer_object_generation.go 80.20% <100.00%> (ø)
pkg/controller/rsm/utils.go 66.99% <100.00%> (+0.13%) ⬆️
controllers/apps/components/component.go 55.38% <50.00%> (+0.03%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om marked this pull request as ready for review October 31, 2023 11:37
@wangyelei
Copy link
Contributor

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 31, 2023
@free6om free6om merged commit 8f6e37f into main Oct 31, 2023
@free6om free6om deleted the support/etcd-powered-by-rsm branch October 31, 2023 14:17
@free6om
Copy link
Contributor Author

free6om commented Oct 31, 2023

/cherry-pick release-0.7

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6707827322

github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
(cherry picked from commit 8f6e37f)
ldming pushed a commit that referenced this pull request Nov 21, 2023
(cherry picked from commit 8f6e37f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test rsm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
4 participants