Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]make lint error #7134

Closed
ahjing99 opened this issue Apr 23, 2024 · 0 comments
Closed

[BUG]make lint error #7134

ahjing99 opened this issue Apr 23, 2024 · 0 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@ahjing99
Copy link
Collaborator

https://github.com/apecloud/kubeblocks/actions/runs/8797973200/job/24143996465

go generate -x ./pkg/testutil/k8s/mocks/...
go run github.com/golang/mock/mockgen -copyright_file ../../../../hack/boilerplate.go.txt -package mocks -destination k[8](https://github.com/apecloud/kubeblocks/actions/runs/8797973200/job/24143996465#step:6:9)sclient_mocks.go sigs.k8s.io/controller-runtime/pkg/client Client,StatusWriter
go generate -x ./pkg/configuration/container/mocks/...
go run github.com/golang/mock/mockgen -copyright_file ../../../../hack/boilerplate.go.txt -package mocks -destination dockerclient_mocks.go github.com/docker/docker/client ContainerAPIClient
go run github.com/golang/mock/mockgen -copyright_file ../../../../hack/boilerplate.go.txt -package mocks -destination criclient_mocks.go k8s.io/cri-api/pkg/apis/runtime/v1 RuntimeServiceClient
go generate -x ./pkg/configuration/proto/mocks/...
go run github.com/golang/mock/mockgen -copyright_file ../../../../hack/boilerplate.go.txt -package mocks -destination reconfigure_client_mocks.go github.com/apecloud/kubeblocks/pkg/configuration/proto ReconfigureClient
mkdir -p /home/runner/work/kubeblocks/kubeblocks/bin
Installing [email protected]...
Successfully installed
/home/runner/work/kubeblocks/kubeblocks/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./apis/...;./externalapis/..."
make golangci-lint
make[1]: Entering directory '/home/runner/work/kubeblocks/kubeblocks'
golangci-lint is already installed
/home/runner/work/kubeblocks/kubeblocks/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./apis/...;./externalapis/..."
/home/runner/go/bin/golangci-lint run ./...
controllers/apps/backuppolicytemplate_controller.go:1: : # github.com/apecloud/kubeblocks/controllers/apps [github.com/apecloud/kubeblocks/controllers/apps.test]
Error: controllers/apps/opsrequest_controller_test.go:1[9](https://github.com/apecloud/kubeblocks/actions/runs/8797973200/job/24143996465#step:6:10)7:6: unknown field ClassDefRef in struct literal of type struct{"github.com/apecloud/kubeblocks/apis/apps/v1alpha1".ComponentOps "json:\",inline\""; "k8s.io/api/core/v1".ResourceRequirements "json:\",inline\""; Instances []"github.com/apecloud/kubeblocks/apis/apps/v1alpha1".PartInstanceTemplate "json:\"instances,omitempty\""}
Error: controllers/apps/opsrequest_controller_test.go:237:37: cannot use scalingCtx.target (variable of type resourceContext) as "k8s.io/api/core/v1".ResourceRequirements value in argument to testapps.MockInstanceSetPod (typecheck)
/*
controllers/apps/operations/backup.go:1: : # github.com/apecloud/kubeblocks/controllers/apps/operations [github.com/apecloud/kubeblocks/controllers/apps/operations.test]
Error: controllers/apps/operations/vertical_scaling_test.go:[12](https://github.com/apecloud/kubeblocks/actions/runs/8797973200/job/24143996465#step:6:13)3:6: unknown field ClassDefRef in struct literal of type struct{"github.com/apecloud/kubeblocks/apis/apps/v1alpha1".ComponentOps "json:\",inline\""; "k8s.io/api/core/v1".ResourceRequirements "json:\",inline\""; Instances []"github.com/apecloud/kubeblocks/apis/apps/v1alpha1".PartInstanceTemplate "json:\"instances,omitempty\""} (typecheck)
/*
make[1]: *** [Makefile:182: golangci-lint] Error 1
make[1]: Leaving directory '/home/runner/work/kubeblocks/kubeblocks'
make: *** [Makefile:[17](https://github.com/apecloud/kubeblocks/actions/runs/8797973200/job/24143996465#step:6:18)8: lint] Error 2
Error: Process completed with exit code 2.
@ahjing99 ahjing99 added the kind/bug Something isn't working label Apr 23, 2024
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants