Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]Switchover improve to support Sharding API #8351

Closed
lancelot1989 opened this issue Oct 29, 2024 · 1 comment
Closed

[Improvement]Switchover improve to support Sharding API #8351

lancelot1989 opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@lancelot1989
Copy link
Contributor

Is your improvement request related to a problem? Please describe.
Currently [kubeblocks 0.9] OpsRequest of Switchover don't support Sharding API, the logic in Switchover didn't consider ShardingSpecs at all. So that those clusters using ShardingSpecs (like redis-cluster) have no chance to do Switchover using OpsRequest.

If this is a new function, please describe the motivation and goals.
Let those clusters using ShardingSpecs can also do Switchover using OpsRequest.

Describe the solution you'd like

  1. Finding Component labels app.kubernetes.io/instance and apps.kubeblocks.io/sharding-name corresponding the cluster and shard.
  2. Finding ComponentDefinition from Component's Spec.CompDef, now we can know the correct ComponentSwitchover
  3. A little adjustment in Switchover's Job name and message in OpsRequest.status.condition to make all fine.

Describe alternatives you've considered
The current solution can not support switchover multiple instance in different shard components. To support this I think we would better update the OpsRequest.Switchover struct.

Additional context
No.

@shanshanying
Copy link
Contributor

supported by a new opsdef instead.

@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants