-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor the dependencies between the cluster, component, and its objects #8809
Conversation
leon-inf
commented
Jan 15, 2025
•
edited
Loading
edited
- Remove the dependency of the cluster on the its object
- Remove the dependency of the component on the cluster object
18160a6
to
f44e709
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8809 +/- ##
==========================================
- Coverage 60.33% 60.23% -0.10%
==========================================
Files 382 382
Lines 46348 46123 -225
==========================================
- Hits 27964 27783 -181
+ Misses 15708 15674 -34
+ Partials 2676 2666 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fcf533c
to
075402c
Compare
075402c
to
0282966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most changes are code refactoring, but I noticed that some Events originally sent to the Cluster CR are now being sent to the Component CR. This could introduce breaking changes or make it difficult to observe or debug the cluster's status. Alternatively, we could introduce an event aggregator to aggregate Component events into Cluster events.
@@ -89,9 +89,9 @@ func (t *componentDeletionTransformer) handleCompDeleteWhenScaleIn(transCtx *com | |||
|
|||
// handleCompDeleteWhenClusterDelete handles the component deletion when the cluster is being deleted, the sub-resources owned by the component depends on the cluster's TerminationPolicy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove or update the comment "depends on the cluster's TerminationPolicy"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
/approve |
/cherry-pick release-1.0-beta |
🤖 says: cherry pick action finished successfully 🎉! |