drop old sequence

apecloud · Dec 27, 2024 · 8107ee0 · 8107ee0
1 parent 3dcda64
commit 8107ee0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/.github/workflows/bats-tests.yml b/.github/workflows/bats-tests.yml
@@ -39,9 +39,6 @@ jobs:
           chmod +x duckdb
           sudo mv duckdb /usr/local/bin
 
-          curl -LJO https://dev.mysql.com/get/Downloads/MySQL-Shell/mysql-shell_9.1.0-1debian12_amd64.deb
-          sudo apt-get install -y ./mysql-shell_9.1.0-1debian12_amd64.deb
-
       - name: Build
         run: go build -v
 

diff --git a/.github/workflows/mysql-copy-tests.yml b/.github/workflows/mysql-copy-tests.yml
@@ -35,20 +35,14 @@ jobs:
         with:
           python-version: '3.13'
 
-      - name: Install system packages
-        uses: awalsh128/cache-apt-pkgs-action@latest
-        with:
-          packages: mysql-client
-          version: 1.0
-
       - name: Install dependencies
         run: |
           go get .
 
           pip3 install "sqlglot[rs]"
 
           curl -LJO https://dev.mysql.com/get/Downloads/MySQL-Shell/mysql-shell_9.1.0-1debian12_amd64.deb
-          sudo apt-get install -y ./mysql-shell_9.1.0-1debian12_amd64.deb
+          sudo dpkg -i -y ./mysql-shell_9.1.0-1debian12_amd64.deb
 
       - name: Setup test data in source MySQL
         run: |

diff --git a/catalog/table.go b/catalog/table.go
@@ -878,6 +878,12 @@ func (t *Table) setAutoIncrementValue(ctx *sql.Context, value uint64) error {
 		return ErrDuckDB.New(err)
 	}
 
+	// Drop the old sequence
+	// https://github.com/duckdb/duckdb/issues/15399
+	// if _, err = adapter.Exec(ctx, "DROP SEQUENCE " + t.comment.Meta.Sequence); err != nil {
+	// 	return ErrDuckDB.New(err)
+	// }
+
 	// Update the table comment with the new sequence name
 	tableInfo := t.comment.Meta
 	tableInfo.Sequence = fullSequenceName