fix: resolve compatibilities for Metabase (#340) #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VWagen1989
force-pushed
the
fix_compatibility
branch
from
1c3f1b2 to
5b3681e
Compare
fanyang01
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- pgserver/connection_data.go: Evaluated as low risk
- pgserver/duck_handler.go: Evaluated as low risk
- pgserver/iter.go: Evaluated as low risk
- catalog/provider.go: Evaluated as low risk
- pgserver/connection_handler.go: Evaluated as low risk
Comments suppressed due to low confidence (3)
pgserver/in_place_handler.go:124
- Ensure that the new InPlaceHandler struct and its methods are covered by tests.
type InPlaceHandler struct {
pgserver/in_place_handler.go:140
- Ensure that the selectionConversions logic is covered by tests, especially the regex patterns and query conversions.
var selectionConversions = []SelectionConversion{
pgserver/in_place_handler.go:374
- Ensure that the updated shouldQueryBeHandledInPlace function is covered by tests, including all its call sites.
func shouldQueryBeHandledInPlace(h *ConnectionHandler, sql *ConvertedStatement) (bool, error) {
…session level pgtypes.Map for each session to encode results
VWagen1989
force-pushed
the
fix_compatibility
branch
from
5519485 to
b84fc11
Compare
fanyang01
reviewed
Jan 9, 2025
|
The failed |
fanyang01
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues of the compatiblities between MyDuck and Metabase.
The other BI tools are not tested yet. If there still be compatibility issues for them, we should open another PR for them.
Ref #340
Resolve #342