Adds support for proto3opt #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to detect optional fields by using `field.Oneof.Desc.IsSynthetic()` and relies on nil checking pointers for the marshall and unmarshalling
|
Thanks for this! Elegant solution I'll just test it against my codebase real quick and then will merge this evening. Thanks again. |
|
Great work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr attempts to detect optional fields by using
field.Oneof.Desc.IsSynthetic()to distinguish betweenoneoffields and optional fields, which are implemented asoneofbetween a type andnil. We also rely on nil checking pointers for the marshall and unmarshalling.This code was able to successfully generate reflectionless opentelemetry-proto-go definitions which use optional fields: gburek-fastly/opentelemetry-proto-go#1
Closes #21