Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tieredProxyUrls accept null for switching the proxy off #687

Closed
barjin opened this issue Nov 12, 2024 · 0 comments · Fixed by #760
Closed

tieredProxyUrls accept null for switching the proxy off #687

barjin opened this issue Nov 12, 2024 · 0 comments · Fixed by #760
Assignees
@Pijukatel
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Milestone
104th sprint - To...

Comments

@barjin
Copy link
Contributor

barjin commented Nov 12, 2024

This is a parity-tracking issue for Crawlee JS / Crawlee Python.

With apify/crawlee#2743 , we enabled ProxyConfiguration.tieredProxyUrls to accept null as a command to switch the proxy off on that tier. In Crawlee JS, this was only a matter of widening the types and making the validation less strict - ProxyConfiguration was already prepared for null URLs (returning null from newUrlFunction - this seems to work in Crawlee for Python too).
@barjin barjin mentioned this issue Nov 12, 2024
Merged
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 12, 2024
@Pijukatel Pijukatel mentioned this issue Nov 28, 2024
Merged
Pijukatel added a commit that referenced this issue Dec 10, 2024
@Pijukatel
feat: Add possibility to use None as no proxy in tiered proxies (#760)
0fbd017 
Using None in input lists for tiered proxy configuration will be
interpreted as no proxy. This allows to have for example lowest tier
without proxy.

Add tests for it.
Update docs.

- Closes: #687
@vdusek vdusek added this to the 104th sprint - Tooling team milestone Dec 10, 2024
@matecsaj matecsaj mentioned this issue Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pijukatel Pijukatel

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
104th sprint - Tooling team
Development

Successfully merging a pull request may close this issue.

feat: Add possibility to use None as no proxy in tiered proxies apify/crawlee-python
3 participants
@vdusek @barjin @Pijukatel