Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using lazy_object_proxy for service_locator to simplify resetting the test environment #884

Open
janbuchar opened this issue Jan 8, 2025 · 0 comments
Open

Consider using lazy_object_proxy for service_locator to simplify resetting the test environment #884

janbuchar opened this issue Jan 8, 2025 · 0 comments
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Collaborator

janbuchar commented Jan 8, 2025 •
edited by vdusek
Loading

If service_locator was a lazy_object_proxy, we could just re-set crawlee._service_locator.service_locator to a new instance of ServiceLocator and we wouldn't need to do this here and in crawlee tests (code duplication across different packages is kinda painful)

Originally posted by @janbuchar in apify/apify-sdk-python#355 (comment)
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jan 8, 2025
@janbuchar janbuchar mentioned this issue Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janbuchar