Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value of persist_state_kvs_name in Statistics and SessionPool causes the use of a named storage on Apify #991

Open
janbuchar opened this issue Feb 17, 2025 · 0 comments
Open

Default value of persist_state_kvs_name in Statistics and SessionPool causes the use of a named storage on Apify #991

janbuchar opened this issue Feb 17, 2025 · 0 comments
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Collaborator

The default value of the argument is "default", but it is used like this: KeyValueStore.open(name=persist_state_kvs_name), which opens a named storage called "default" when running on Apify.

Possible solutions

  1. accept a pre-opened KeyValueStore instance instead
  2. accept a type that distinguishes names/IDs/nothing - kinda verbose in Python

Note - after #809, this change will be easier to do consistently.
@janbuchar janbuchar added the bug Something isn't working. label Feb 17, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janbuchar