Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Pool does not await _createPageForBrowser #2789

Open
1 task
danielcrabtree opened this issue Jan 4, 2025 · 0 comments
Open
1 task

Browser Pool does not await _createPageForBrowser #2789

danielcrabtree opened this issue Jan 4, 2025 · 0 comments
Assignees
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@danielcrabtree
Copy link

Which package is this bug report for? If unsure which one to select, leave blank

@crawlee/browser-pool

Issue description

The newPage and newPageInNewBrowser functions in BrowserPool both return _createPageForBrowser() without awaiting the result. This causes the browser to hang under certain difficult to reproduce race conditions - adding await to these calls appears to resolve these race conditions.

Code sample

No response

Package version

3.12.1

Node.js version

22

Operating system

No response

Apify platform

  • Tick me if you encountered this issue on the Apify platform

I have tested this on the next release

No response

Other context

No response

@danielcrabtree danielcrabtree added the bug Something isn't working. label Jan 4, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jan 4, 2025
@B4nan B4nan self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants