Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headerGenerator behaves differently than expected for safari browser #346

Open
kashif-ghafoor opened this issue Dec 30, 2024 · 0 comments
Open
Labels
bug Something isn't working.

Comments

@kashif-ghafoor
Copy link

Describe the bug

headerGenerator

  1. throws error for browserListQuery "last n safari version" where n is any number
  2. if I set minVersion to 18 it produces headers for safari browser version lower than 18 even with strict property set to true

To Reproduce

case 1

// will produce "No headers based on this input can be generated" error
const generator = new HeaderGenerator({
  browserListQuery: "last 10 safari version",
  operatingSystems: ["macos"],
  devices: ["desktop"],
});

case 2

// will produce headers for browser version lower than 18
const generator = new HeaderGenerator({
  browsers: [
    {
      name: "safari",
      minVersion: 18,
    },
  ],
  operatingSystems: ["macos"],
  devices: ["desktop"],
  strict: true,
});

Expected behavior
for case 1 we expect the generator to generate headers
for case 2 we expect it to produce headers with safari version >= 18

System information:

  • OS: MacOS
  • Node.js version 22
  • header-generator version 2.1.61
@kashif-ghafoor kashif-ghafoor added the bug Something isn't working. label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant