Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint TODO comments in CI #74

Open
apollo-sturdy opened this issue Nov 18, 2022 · 1 comment
Open

Lint TODO comments in CI #74

apollo-sturdy opened this issue Nov 18, 2022 · 1 comment
Assignees
@apollo-bobby
Labels
enhancement New feature or request

Comments

@apollo-sturdy
Copy link
Contributor

We shouldn't leave TODO comments in the code. Better to create issues.
@apollo-sturdy apollo-sturdy added the enhancement New feature or request label Nov 21, 2022
@apollo-bobby
Copy link
Contributor

Clippy is unable to do this as it can't see comments (nor does it have a rule for it) and the feature has been removed from rustfmt (See rust-lang/rustfmt#5101).
We will have to find a third-party solution or make something ourselves if we want to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apollo-bobby apollo-bobby

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apollo-sturdy @apollo-bobby