Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data masking] Allow useFragment to work with no-cache queries #11678

Closed
jerelmiller opened this issue Mar 14, 2024 · 4 comments · Fixed by #12121
Closed

[Data masking] Allow useFragment to work with no-cache queries #11678

jerelmiller opened this issue Mar 14, 2024 · 4 comments · Fixed by #12121
Labels
🎭 data-masking Issues/PRs related to data masking
Milestone

Comments

@jerelmiller
Copy link
Member

Subject to change based on technical exploration

@jerelmiller jerelmiller added this to the Data masking milestone Mar 14, 2024
@alessbell alessbell added the 🎭 data-masking Issues/PRs related to data masking label Jun 7, 2024
@jerelmiller
Copy link
Member Author

As a starting point, we are going to leave useFragment alone because introducing support for no-cache would turn it into a "polymorphic" hook which might be confusing.

Instead, we plan to warn when using no-cache with data masking and require that you use @unmask in order to get the full data result. This option gives us the most flexibility to update this in the future if we find it to be problematic in a non-breaking way.

@jerelmiller
Copy link
Member Author

Finished with #12121

Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎭 data-masking Issues/PRs related to data masking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants