Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing utilities] Create separate entrypoint for new testing utilities #11780

Closed
alessbell opened this issue Apr 12, 2024 · 4 comments · Fixed by #11783
Closed

[Testing utilities] Create separate entrypoint for new testing utilities #11780

alessbell opened this issue Apr 12, 2024 · 4 comments · Fixed by #11783

Comments

@alessbell
Copy link
Contributor

Issue Description

The new testing utilities will have at least a couple of peer dependencies.

For now, we'll advise users to install them in the docs. If we export the new testing utilities that import these peer dependencies in our regular .cjs testing entrypoint, other users will see an error if they're not installed.

If we make these explicit dependencies, all our users will download them whether or not they're using the new testing utilities, so I proposed a few options and discussed with @phryneas and for now we'll opt for a separate entrypoint.

Link to Reproduction

N/A

Reproduction Steps

No response

@apollo/client version

N/A

@alessbell
Copy link
Contributor Author

alessbell commented Apr 12, 2024

Thoughts on the entrypoint name @phryneas @jerelmiller? Should it be feature-specific (testSchema/createTestSchema) or something like alpha-testing?

Edit: went with testing/alpha for now

@alessbell
Copy link
Contributor Author

Closed via #11783

Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant