Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests affected by change to cache #12330

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

jerelmiller
Copy link
Member

Fixes tests changed by #12327 that now check for the data property and not caught when doing the cache.diff change in #12304

@svc-apollo-docs
Copy link

svc-apollo-docs commented Jan 31, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 0513b3f72053eb67bf9e9970

Copy link

pkg-pr-new bot commented Jan 31, 2025

npm i https://pkg.pr.new/@apollo/client@12330

commit: 012033b

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 012033b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2025

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 33.47 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 41.41 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 38.72 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.15 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.55 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.12 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.21 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.61 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.68 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.01 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 1.95 KB (0%)

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit abcbc92
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/679d04e4f236cc0008c2af6b
😎 Deploy Preview https://deploy-preview-12330--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 012033b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/679d070403ecaa000755329b
😎 Deploy Preview https://deploy-preview-12330--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller jerelmiller force-pushed the jerel/fix-tests-affected-by-cache-change branch from 3d387c2 to 48711e6 Compare January 31, 2025 17:22
@jerelmiller jerelmiller force-pushed the jerel/fix-tests-affected-by-cache-change branch from 48711e6 to 012033b Compare January 31, 2025 17:23
@jerelmiller jerelmiller merged commit 0429fb9 into release-4.0 Jan 31, 2025
48 checks passed
@jerelmiller jerelmiller deleted the jerel/fix-tests-affected-by-cache-change branch January 31, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants