Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login-form.tsx references a lower case non-existent interface #197

Open
jonasatmonday opened this issue Jan 21, 2021 · 2 comments
Open

login-form.tsx references a lower case non-existent interface #197

jonasatmonday opened this issue Jan 21, 2021 · 2 comments

Comments

@jonasatmonday
Copy link

Hello everybody,

/final/client/src/components/login-forms.tsx references LoginTypes.loginVariables from login.ts which does not exist. It needs to be LoginTypes.LoginVariables instead.

Currently, it is not possible to start the final client because of this bug.

I already prepared a commit for this fix but can't push it to a new branch because I have no push permission for this repo. How can I get the push permission for new branches?

Thanks a lot and best regards,
Jonas

@lanshunfang
Copy link

It happens to me too. It's fixed in the commit #202, but still waiting for merge.

BTW, I am somehow surprised Apollographql allows compilation error checkins to master branch.

@jonasatmonday
Copy link
Author

@lanshunfang me too! I would assume they have some CI/CD pipelines in place to prevent this kind of stuff from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants