Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enablePassportStrategies is now async #23

Merged
merged 5 commits into from
Oct 25, 2024
Merged

enablePassportStrategies is now async #23

merged 5 commits into from
Oct 25, 2024

Conversation

haroun
Copy link
Contributor

@haroun haroun commented Sep 20, 2024

Summary

Support apostrophe async apos.root.import

What are the specific steps to test this change?

  1. Start an ESM project with passport bridge setup.
  2. Look for error messages
  3. Validate that the login is still possible

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@haroun haroun self-assigned this Sep 20, 2024
Copy link

linear bot commented Sep 20, 2024

@haroun haroun marked this pull request as ready for review October 18, 2024 17:07
@haroun haroun requested a review from boutell October 18, 2024 17:07
node-version: [14, 16, 18]
mongodb-version: [4.2, 4.4, 5.0]
node-version: [18, 20, 22]
mongodb-version: [5.0, 6.0, 7.0, 8.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop mongo 5 EOL this month

@haroun haroun merged commit f5fd3d8 into main Oct 25, 2024
9 checks passed
@haroun haroun deleted the pro-6133-esm branch October 25, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants