Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next starter kit - ESM & Vite #25

Merged
merged 10 commits into from
Dec 18, 2024
Merged

next starter kit - ESM & Vite #25

merged 10 commits into from
Dec 18, 2024

Conversation

myovchev
Copy link
Contributor

@myovchev myovchev commented Nov 8, 2024

Summary

The next branch is the official next release of the starter kit - ESM + Vite build.

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@myovchev myovchev marked this pull request as draft November 8, 2024 11:34
@myovchev myovchev changed the title next starter kit - ESM & Vite next starter kit - ESM & Vite Nov 8, 2024
@myovchev myovchev mentioned this pull request Nov 8, 2024
10 tasks
@myovchev myovchev requested a review from haroun November 8, 2024 11:36
package.json Outdated Show resolved Hide resolved
docs/developer/getting-started.md Outdated Show resolved Hide resolved
@@ -48,7 +47,8 @@
"dependencies": {
"@apostrophecms/open-graph": "^1.2.1",
"@apostrophecms/seo": "^1.2.0",
"apostrophe": "^4.0.0",
"@apostrophecms/vite": "github:apostrophecms/vite",
"apostrophe": "github:apostrophecms/apostrophe",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: revert back to versions after release

@myovchev myovchev requested review from haroun and BoDonkey November 11, 2024 12:26
@boutell boutell merged commit d2f28f1 into main Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants