Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably wrong dependencies #616

Open
doitwithnotepad opened this issue Sep 2, 2024 · 0 comments
Open

Probably wrong dependencies #616

doitwithnotepad opened this issue Sep 2, 2024 · 0 comments

Comments

@doitwithnotepad
Copy link
Contributor

doitwithnotepad commented Sep 2, 2024

Describe the problem/bug
if you install thunderhub for production it does not install the dependencies correctly, because one of them is as development dep.

Your environment

  • Version of ThunderHub: 0.13.31
  • Deployment method: source
  • Other relevant environment details: Alpinelinux 3.20.2 | node v21.7.3 | npm 10.8.0

To Reproduce
Steps to reproduce the behavior:

  1. cd /tmp
  2. git clone --branch v0.13.31 https://github.com/apotdevin/thunderhub.git && cd thunderhub
  3. npm install --omit=dev --omit=optional
  4. See error

Expected behavior
install runtime dependencies

Actual behavior
this:

> [email protected] prepare
> husky install

sh: husky: not found
npm error code 127
npm error path /tmp/thunderhub
npm error command failed
npm error command sh -c husky install
npm error A complete log of this run can be found in: /tmp/thunderhub/npm-cache/_logs/2024-09-02T15_26_46_984Z-debug-0.log

Screenshots/Links
not applicable

Additional context
possible solution:
package.json

 [...]
   "dependencies": {
 [...]
+    "husky": "^8.0.3",
 [...]
   "devDependencies": {
 [...]
-    "husky": "^8.0.3",
 [...]

also i can bypass this issue with step 3 replaced by: npm install husky --omit=dev --omit=optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant