From d7f475e5139250b4384ec6b869c07febc2ca0da2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ricardo=20L=C3=BCders?= <rluders@redhat.com>
Date: Fri, 19 Apr 2024 14:24:07 +0200
Subject: [PATCH] DVO-205: (chore) replace golint (#321)

* chore: replace golint with revive

* style: fix revive reports
---
 .golangci.yml                | 6 +-----
 internal/testing/client.go   | 2 +-
 pkg/prometheus/prometheus.go | 1 +
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 34d8cf1f..f83cc2af 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -6,7 +6,7 @@ linters:
   enable:
   - gofmt
   - goimports
-  - golint
+  - revive
   - govet
   - misspell
   - unused
@@ -18,10 +18,6 @@ linters:
   - staticcheck
 
 linters-settings:
-  golint:
-    # minimal confidence for issues, default is 0.8
-    min-confidence: 0
-
   lll:
     line-length: 120
     tab-width: 8
diff --git a/internal/testing/client.go b/internal/testing/client.go
index 1867c96b..6f9a4300 100644
--- a/internal/testing/client.go
+++ b/internal/testing/client.go
@@ -27,7 +27,7 @@ func (c *TestClient) Create(ctx context.Context, obj client.Object, opts ...Requ
 	}
 }
 
-func (c *TestClient) Update(ctx context.Context, obj client.Object, opts ...RequestOption) {
+func (c *TestClient) Update(ctx context.Context, obj client.Object, _ ...RequestOption) {
 	gomega.ExpectWithOffset(1, c.client.Update(ctx, obj)).Should(gomega.Succeed())
 }
 
diff --git a/pkg/prometheus/prometheus.go b/pkg/prometheus/prometheus.go
index 8ff8241a..728506e7 100644
--- a/pkg/prometheus/prometheus.go
+++ b/pkg/prometheus/prometheus.go
@@ -171,6 +171,7 @@ func (s *Server) Start(ctx context.Context) error {
 	errCh := make(chan error)
 	drain := func() {
 		for range errCh {
+			continue
 		}
 	}