Skip to content

Commit 00cd6fb

Browse files
author
vikasrohit
authored
Merge pull request #3293 from appirio-tech/hotfix/security-comp-10
Hotfix/security comp 10
2 parents 32136b1 + 3238c43 commit 00cd6fb

File tree

9 files changed

+29
-7
lines changed

9 files changed

+29
-7
lines changed

config/constants/dev.js

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ module.exports = {
3535

3636
FILE_PICKER_API_KEY: process.env.FILE_PICKER_API_KEY_DEV,
3737
FILE_PICKER_SUBMISSION_CONTAINER_NAME: 'submission-staging-dev',
38+
FILE_PICKER_ACCEPT: process.env.FILE_PICKER_ACCEPT_DEV,
3839

3940
SALESFORCE_PROJECT_LEAD_LINK: 'https://c.cs18.visual.force.com/apex/ConnectLead?connectProjectId=',
4041

config/constants/master.js

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ module.exports = {
3636

3737
FILE_PICKER_API_KEY: process.env.FILE_PICKER_API_KEY_PROD,
3838
FILE_PICKER_SUBMISSION_CONTAINER_NAME: 'submission-staging-prod',
39+
FILE_PICKER_ACCEPT: process.env.FILE_PICKER_ACCEPT_PROD,
3940

4041
SALESFORCE_PROJECT_LEAD_LINK: 'https://topcoder.my.salesforce.com/apex/ConnectLead?connectProjectId=',
4142
CONNECT_SEGMENT_KEY: process.env.PROD_SEGMENT_KEY,

config/constants/qa.js

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ module.exports = {
3535

3636
FILE_PICKER_API_KEY: process.env.FILE_PICKER_API_KEY_QA,
3737
FILE_PICKER_SUBMISSION_CONTAINER_NAME: 'submission-staging-qa',
38+
FILE_PICKER_ACCEPT: process.env.FILE_PICKER_ACCEPT_QA,
3839

3940
SALESFORCE_PROJECT_LEAD_LINK: 'https://c.cs18.visual.force.com/apex/ConnectLead?connectProjectId=',
4041
CONNECT_SEGMENT_KEY: process.env.QA_SEGMENT_KEY,

src/components/Feed/NewPostMobile.jsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ import {
2121
FILE_PICKER_API_KEY,
2222
FILE_PICKER_CNAME,
2323
FILE_PICKER_FROM_SOURCES,
24-
FILE_PICKER_SUBMISSION_CONTAINER_NAME, PROJECT_ATTACHMENTS_FOLDER
24+
FILE_PICKER_SUBMISSION_CONTAINER_NAME,
25+
PROJECT_ATTACHMENTS_FOLDER,
26+
FILE_PICKER_ACCEPT,
2527
} from '../../config/constants'
2628
import BtnRemove from '../../assets/icons/ui-16px-1_trash-simple.svg'
2729
import _ from 'lodash'
@@ -114,6 +116,7 @@ class NewPostMobile extends React.Component {
114116
},
115117
maxFiles: 4,
116118
fromSources: FILE_PICKER_FROM_SOURCES,
119+
accept: FILE_PICKER_ACCEPT,
117120
uploadInBackground: false,
118121
onFileUploadFinished: (files) => {
119122
this.processUploadedFiles(files)

src/components/FileList/AddFiles.jsx

+8-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,13 @@ import PropTypes from 'prop-types'
33
import FilePicker from 'appirio-tech-react-components/components/FilePicker/FilePicker'
44
import './AddFiles.scss'
55

6-
import { FILE_PICKER_API_KEY, FILE_PICKER_SUBMISSION_CONTAINER_NAME, FILE_PICKER_CNAME, FILE_PICKER_FROM_SOURCES } from '../../config/constants'
6+
import {
7+
FILE_PICKER_API_KEY,
8+
FILE_PICKER_SUBMISSION_CONTAINER_NAME,
9+
FILE_PICKER_CNAME,
10+
FILE_PICKER_FROM_SOURCES,
11+
FILE_PICKER_ACCEPT
12+
} from '../../config/constants'
713

814
const AddFiles = props => {
915
const { successHandler, category, storePath } = props
@@ -20,6 +26,7 @@ const AddFiles = props => {
2026
location: 's3',
2127
storeContainer: FILE_PICKER_SUBMISSION_CONTAINER_NAME,
2228
fromSources: FILE_PICKER_FROM_SOURCES,
29+
accept: FILE_PICKER_ACCEPT,
2330
path: storePath,
2431
multiple: 'true',
2532
services: ['COMPUTER', 'GOOGLE_DRIVE', 'BOX', 'DROPBOX', 'SKYDRIVE']

src/components/LinksMenu/FileLinksMenu.jsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ import {
2121
FILE_PICKER_API_KEY,
2222
FILE_PICKER_FROM_SOURCES,
2323
FILE_PICKER_CNAME,
24-
FILE_PICKER_SUBMISSION_CONTAINER_NAME
24+
FILE_PICKER_SUBMISSION_CONTAINER_NAME,
25+
FILE_PICKER_ACCEPT,
2526
} from '../../config/constants'
2627

2728
const FileLinksMenu = ({
@@ -119,6 +120,7 @@ const FileLinksMenu = ({
119120
},
120121
maxFiles: 4,
121122
fromSources: FILE_PICKER_FROM_SOURCES,
123+
accept: FILE_PICKER_ACCEPT,
122124
uploadInBackground: false,
123125
onFileUploadFinished: (files) => {
124126
processUploadedFiles(files, category)

src/components/RichTextArea/RichTextArea.jsx

+5-2
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@ import TitleSaveIcon from '../../assets/icons/icon-save.svg'
2727

2828
import {
2929
FILE_PICKER_API_KEY,
30-
FILE_PICKER_CNAME, FILE_PICKER_FROM_SOURCES,
30+
FILE_PICKER_CNAME,
31+
FILE_PICKER_FROM_SOURCES,
3132
FILE_PICKER_SUBMISSION_CONTAINER_NAME,
32-
PROJECT_ATTACHMENTS_FOLDER
33+
PROJECT_ATTACHMENTS_FOLDER,
34+
FILE_PICKER_ACCEPT,
3335
} from '../../config/constants'
3436
import * as filepicker from 'filestack-js'
3537
import BtnRemove from '../../assets/icons/ui-16px-1_trash-simple.svg'
@@ -339,6 +341,7 @@ class RichTextArea extends React.Component {
339341
},
340342
maxFiles: 4,
341343
fromSources: FILE_PICKER_FROM_SOURCES,
344+
accept: FILE_PICKER_ACCEPT,
342345
uploadInBackground: false,
343346
onFileUploadFinished: (files) => {
344347
this.processUploadedFiles(files)

src/config/constants.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -644,11 +644,12 @@ export const ROLE_ADMINISTRATOR = 'administrator'
644644
export const ROLE_CONNECT_COPILOT_MANAGER = 'Connect Copilot Manager'
645645

646646
// FIXME .. remove defaults
647-
export const FILE_PICKER_API_KEY = process.env.FILE_PICKER_API_KEY || 'AzFINuQoqTmqw0QEoaw9az'
647+
export const FILE_PICKER_API_KEY = process.env.FILE_PICKER_API_KEY || ''
648648
export const FILE_PICKER_SUBMISSION_CONTAINER_NAME = process.env.FILE_PICKER_SUBMISSION_CONTAINER_NAME || 'submission-staging-dev'
649649
export const FILE_PICKER_CNAME = process.env.FILE_PICKER_CNAME || 'fs.topcoder.com'
650650
export const FILE_PICKER_FROM_SOURCES = process.env.FILE_PICKER_FROM_SOURCES || ['local_file_system', 'googledrive', 'dropbox']
651651
export const PROJECT_ATTACHMENTS_FOLDER = process.env.PROJECT_ATTACHMENTS_FOLDER || 'PROJECT_ATTACHMENTS'
652+
export const FILE_PICKER_ACCEPT = process.env.FILE_PICKER_ACCEPT || ['.bmp', '.gif', '.jpg', '.tex', '.xls', '.xlsx', '.doc', '.docx', '.zip', '.txt', '.pdf', '.png', '.ppt', '.pptx', '.rtf']
652653

653654
export const SEGMENT_KEY = process.env.CONNECT_SEGMENT_KEY
654655
/*

src/projects/detail/containers/AssetsInfoContainer.jsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ import { PROJECT_ATTACHMENTS_FOLDER,
1919
FILE_PICKER_API_KEY,
2020
FILE_PICKER_FROM_SOURCES,
2121
FILE_PICKER_CNAME,
22-
FILE_PICKER_SUBMISSION_CONTAINER_NAME } from '../../../config/constants'
22+
FILE_PICKER_SUBMISSION_CONTAINER_NAME,
23+
FILE_PICKER_ACCEPT,
24+
} from '../../../config/constants'
2325
import AddLink from '../../../components/AssetsLibrary/AddLink'
2426
import PERMISSIONS from '../../../config/permissions'
2527
import { checkPermission } from '../../../helpers/permissions'
@@ -517,6 +519,7 @@ class AssetsInfoContainer extends React.Component {
517519
},
518520
maxFiles: 4,
519521
fromSources: FILE_PICKER_FROM_SOURCES,
522+
accept: FILE_PICKER_ACCEPT,
520523
uploadInBackground: false,
521524
onFileUploadFinished: (files) => {
522525
processUploadedFiles(files, category)

0 commit comments

Comments
 (0)