Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle "Reset Password" to match new styles #934

Closed
vikasrohit opened this issue Jun 30, 2017 · 9 comments
Closed

Restyle "Reset Password" to match new styles #934

vikasrohit opened this issue Jun 30, 2017 · 9 comments
Assignees

Comments

@vikasrohit
Copy link

This is the page which is loaded when user clicks on reset password link in his/her email.

cc: @fnisen @vic-topcoder

@vikasrohit vikasrohit self-assigned this Jun 30, 2017
@vikasrohit
Copy link
Author

I have tried to style it similar to forgot password page. Here are screen shots after restyle. Please let me know if anything else needed.

screen shot 2017-06-30 at 12 26 13 pm

screen shot 2017-06-30 at 12 24 34 pm

@fnisen @vic-topcoder I have also taken the liberty to remove the automatic redirection to the login page after successful reset of password. IMO, user was not getting any information if the password update was successful or not. So, I have instead rendered a success message and provided the link to login. If it might create bad UX, please let me know I can revert the changes.

@fnisen
Copy link
Contributor

fnisen commented Jun 30, 2017

@vikasrohit yes, I don't want to create extra steps for the user. Can you please keep the login redirection and just show a confirmation system message? I think that's what we had previously, at least on the member side. In fact, I tried to test this, but the Reset Password flow was not working for me: https://www.screencast.com/t/n46cZGGuy. It would seem like I was stuck on the reset screen, after creating a new password... until I reloaded the Dashboard and would be logged in. Can you please look into that, as well.

@fnisen fnisen added the P1 label Jun 30, 2017
@vikasrohit
Copy link
Author

We can not show the confirmation message along with redirection because by the time browser would try to render that message, it already has been redirected to login. It does not informs the user that if password reset was successful or not.

That issue on production, seems to be because some HTTPs and HTTP conflict. It is working fine on local with new flow at least. Still, I would check.

@vikasrohit
Copy link
Author

@fnisen Got idea of redirecting user with message. However, I don't think it is working in member side though right now. It might be there before we moved the login/reg to separate app. We can add that behaviour again to member side as well. However, it would be nice if we can do that after this release, you can create an issue for that in accounts-app.

Need more help from @vic-topcoder to style this:
screen shot 2017-07-03 at 12 32 45 pm

Changes are in dev.

@fnisen
Copy link
Contributor

fnisen commented Jul 5, 2017

@vikasrohit is it possible to login the user (redirect to connect app) and then throw a toaster message in connect app confirming the change?

I don't like the extra login; worst case we can just not show the confirmation. (Confirmed this with @vic-topcoder).

@vikasrohit
Copy link
Author

We can try that, but I would suggest we should do it after the release.

@fnisen
Copy link
Contributor

fnisen commented Jul 8, 2017

OK, sounds good. Created issue to track that: #951. For now, can you please just automatically redirect and login the user, without the toaster message?

@vikasrohit
Copy link
Author

@fnisen Created separate issue for this because this issue is more concerned about the style of the form and this feature might go under shadow of styling issue.
I guess we can safely close this now.

@fnisen
Copy link
Contributor

fnisen commented Jul 10, 2017

Agree, closing.

@fnisen fnisen closed this as completed Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants